Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript_indexer): emit overrides edges for methods that are 2+ levels away #5725

Conversation

nbeloglazov
Copy link
Collaborator

This fixes the following scenario:

class One { 
  doStuff() {}
}

class Two extends One {}

class Three extends Two {
  override doStuff() {}
}

Previously TS indexer didn't emit overrides edge between doStuff methods. Now TS indexer traverses all parent class chain until it finds a class/interface that contains method in question or until it reaches base class/interface.

@nbeloglazov nbeloglazov enabled auto-merge (squash) June 30, 2023 15:53
@nbeloglazov nbeloglazov merged commit 580ced8 into kythe:master Jun 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants