Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cxx_indexer): add GraphObserver.recordDiagnostic() #5730

Merged
merged 8 commits into from
Jul 17, 2023
Merged

feat(cxx_indexer): add GraphObserver.recordDiagnostic() #5730

merged 8 commits into from
Jul 17, 2023

Conversation

justbuchanan
Copy link
Contributor

No description provided.

@justbuchanan justbuchanan requested review from shahms and a team June 30, 2023 23:07
shahms
shahms reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@shahms shahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple minor follow-ups.

kythe/cxx/indexer/cxx/GraphObserver.h Outdated Show resolved Hide resolved
kythe/cxx/indexer/cxx/KytheGraphObserver.cc Outdated Show resolved Hide resolved
@justbuchanan justbuchanan merged commit 49f5768 into kythe:master Jul 17, 2023
5 checks passed
@justbuchanan justbuchanan deleted the diagnostic branch July 17, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahms shahms shahms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justbuchanan @shahms