feat(api): support MarkedSource MODIFIER type #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support having modifiers such as "public", "func", etc. in MarkedSource without relying on the generic BOX kind.
zrlk
reviewed
Aug 7, 2023
| // - LTFunc.pre_text "func " | ||
| // - LTFunc.kind "MODIFIER" | ||
| // - LTFunc.pre_text "func" | ||
| // - LTFunc.post_text " " |
There was a problem hiding this comment.
My understanding is that eventually we want to make this space part of the post_child_text of the enclosing BOX (but that's a larger refactoring that doesn't belong in this change).
There was a problem hiding this comment.
I'm not sure it matters in this particular case.
zrlk
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support having modifiers such as "public", "func", etc. in MarkedSource without relying on the generic BOX kind.