Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cxx_indexer): properly handle dependent using decl names #5808

Merged
merged 2 commits into from Aug 23, 2023
Merged

fix(cxx_indexer): properly handle dependent using decl names #5808

merged 2 commits into from Aug 23, 2023

Conversation

shahms
Copy link
Contributor

@shahms shahms commented Aug 23, 2023

They tell me binding a reference to a null pointer is bad.

@shahms shahms requested review from zrlk and a team August 23, 2023 21:13
@shahms shahms enabled auto-merge (squash) August 23, 2023 21:14
@shahms shahms requested a review from jaysachs August 23, 2023 21:14
zrlk
zrlk approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@zrlk zrlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If undefined behavior were bad surely they would have called it bad behavior

@shahms shahms merged commit 7864f66 into kythe:master Aug 23, 2023
5 checks passed
@shahms shahms deleted the cxx-print-dependent-using branch August 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrlk zrlk zrlk approved these changes

@jaysachs jaysachs Awaiting requested review from jaysachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shahms @zrlk