fix(verifier): request larger stack size for new solver #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future we can look at doing a smarter job lowering to datalog (e.g. not adding every goal into the same giant Horn clause, which was causing souffle to bump up against the stack). For now, just asking for a larger stack allows all the Go tests to pass; tested this by running them with the flag fixed to true.
shahms
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future we can look at doing a smarter job lowering to datalog (e.g. not adding every goal into the same giant Horn clause, which was causing souffle to bump up against the stack). For now, just asking for a larger stack allows all the Go tests to pass; tested this by running them with the flag fixed to true.