feat(verifier): support error recovery with the fast solver #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds error recovery to the fast solver. It behaves like recovery in the old solver (where the first goal/goal group to fail in linear order are reported). Unfortunately, we have to do this by re-running the solver while we walk back each individual goal. Note that UseFileNodes should be called *before* any parsing function. This already happens in verifier_main, but some tests were calling it afterward. The old solver does a bunch of work in PrepareDatabase (including handling assertions in file nodes), while the fast solver handles everything during parsing. (This avoids an expensive sort.)
shahms
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds error recovery to the fast solver. It behaves like recovery in the old solver (where the first goal/goal group to fail in linear order are reported). Unfortunately, we have to do this by re-running the solver while we walk back each individual goal.
Note that UseFileNodes should be called before any parsing function. This already happens in verifier_main, but some tests were calling it afterward. The old solver does a bunch of work in PrepareDatabase (including handling assertions in file nodes), while the fast solver handles everything during parsing. (This avoids an expensive sort.)