This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Create from_dict method for Interface, UNI, Switch and Link #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #1043 |
hdiogenes
suggested changes
Apr 2, 2020
There was a problem hiding this comment.
As we've discussed in the last meeting, this approach will have the downside of creating many instances of the same Interface object (with different values for the available_tags attribute, for example).
On the other hand, this is the approach which is already being done in some NApps, so at least we can centralize the logic here, and when we fix this it'll be fixed for all NApps that depend upon it.
cmagnobarbosa
force-pushed
the
switch_from_dict
branch
from
88b871a
to
a8ef3d3
Compare
Some classes, like Interface and UNI, do not have a from_dict method. This commit solves this problem.
cmagnobarbosa
force-pushed
the
switch_from_dict
branch
from
a8ef3d3
to
032f4fd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some classes, like Interface, UNI, Switch and Link do not have a from_dict method. This commit solves this problem.
Related #1043