This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Remove authenticated decorator from shutdown API command #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemauro
force-pushed
the
fix-issue-1248
branch
2 times, most recently
from
8f271d0
to
53e418f
Compare
josemauro
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #1227 #1248
After discussions between me, @hdiogenes , @italovalcy and @rmotitsuki the conclusion is that shutdown endpoint is designed to make possible to shutdown the API server and not to shutdown Kytos. This PR revert the changes that
was applied in #1231 following the demand that have arisen from PR #1227. Besides that, this PR propose better names and descriptions to make clear that the shudown edpoint is not intended to finish kytos.