Add VoNR & VoCrossSIM toggle support #45
Conversation
hdoublearp
changed the title
|
Hi! Thanks for your contribution. Is there an actual carrier operating VoNR right now so that we can test if this really works? @hdoublearp |
|
While I cannot comment on VoNR, the cross-sim calling feature is awesome! At first I was confused what it does. The setting it enables is called "Backup calling": |
Happy to contribute! Yes, indeed there is VoNR live on T-Mobile in the United States, on their NR-SA n71, n25, and n41 network. I can confirm that this boolean is valid and functional on the Pixel 6 Pro for enabling VoNR on the network. It also seems to work on Qualcomm, but unfortunately there is a NV item in the baseband filesystem which dictates whether IMS can be registered when connected to SA networks (/nv/item_files/modem/mmode/nr5g_full_voice_support). When enabled (set to 0x01) the toggle works. That being said, I feel that if it's working for Pixel that it's worth merging. Thanks for the feedback. :) |
It's a new feature in Android 13 which seems to be disabled by default. iOS has had this feature for quite some time, I'm excited to see this on Android. 😄 |
|
Added VoNR setting visibility bool. Tested with Xperia 1 IV. |
|
@hdoublearp Great! Thanks for the report. Please the merge conflicts. After that I will be really happy to merge this PR. |
|
I've been testing the cross-sim feature and it's not required to enable KEY_ENABLE_CROSS_SIM_CALLING_ON_OPPORTUNISTIC_DATA_BOOL to make it work. One thing worth nothing is that the second SIM that provides mobile data must not be roaming, else "Backup calling" won't work, see: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/telephony/java/android/telephony/ims/ImsMmTelManager.java;l=1014-1047 I'm currently using a "travel eSIM" for mobile data and it is roaming in the country I'm in now, so a workaround to make "Backup calling" work was to enable KEY_FORCE_HOME_NETWORK_BOOL for the mobile data SIM. |
|
Has this been merged yet? The latest version doesn't have the vonr toggle |
No. |
|
I tested the apk for VoNR from this branch. It works perfectly in Pixel 6 and 6A. The changes work. |
Hi, I would love to test this build but I don't seems to find the place I can download the APK, where did you get it? |
The owner of that repository hasn't published an APK but if you got Android Studio you can 'Get from VCS' and link it to his repository and then run it on your device like usual |
|
@kyujin-cho I will need to rebase, because there was some logic changes in moder.kt and config.kt, where instead of "BooleanPropertyView(label" you are now using BooleanPropertyView(label = stringResource(R.string.". I will update the PR with the additional commits with the rebase and hopefully you can merge then. |
|
I have rebased and resolved the conflicts. Please review, and let me know! |
|
@hdoublearp Logic seems fine. Please just update code to fix lint issues. |
|
@kyujin-cho lint should be fixed now :) |
|
Waiting for a 1.2.5 release version 😀 |
This adds VoNR toggle support. Devices supporting SA may or may not have VoNR toggle setting visible. The default bool value for the toggle is false per AOSP. Requires modem support to truly work, but that is independent of Android.