issue fixed (#1558)

Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
kyverno · Feb 8, 2021 · c148573 · c148573
1 parent 72eb5e3
commit c148573
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/pkg/engine/utils.go b/pkg/engine/utils.go
@@ -146,7 +146,7 @@ func doesResourceMatchConditionBlock(conditionBlock kyverno.ResourceDescription,
 		}
 	}
 
-	if conditionBlock.NamespaceSelector != nil && namespaceLabels != nil && resource.GetKind() != "Namespace" && resource.GetKind() != "" {
+	if conditionBlock.NamespaceSelector != nil && resource.GetKind() != "Namespace" && resource.GetKind() != "" {
 		hasPassed, err := checkSelector(conditionBlock.NamespaceSelector, namespaceLabels)
 		if err != nil {
 			errs = append(errs, fmt.Errorf("failed to parse namespace selector: %v", err))

diff --git a/pkg/generate/generate_controller.go b/pkg/generate/generate_controller.go
@@ -60,12 +60,6 @@ type Controller struct {
 	// dynamic shared informer factory
 	dynamicInformer dynamicinformer.DynamicSharedInformerFactory
 
-	// // nsLister can list/get namespaces from the shared informer's store
-	// nsLister listerv1.NamespaceLister
-
-	// // nsListerSynced returns true if the namespace store has been synced at least once
-	// nsListerSynced cache.InformerSynced
-
 	//TODO: list of generic informers
 	// only support Namespaces for re-evaluation on resource updates
 	nsInformer           informers.GenericInformer
@@ -134,9 +128,6 @@ func NewController(
 		UpdateFunc: c.updateGenericResource,
 	})
 
-	// c.nsLister = namespaces.Lister()
-	// c.nsListerSynced = namespaces.Informer().HasSynced
-
 	return &c, nil
 }