Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Helm Release Process #2057

Closed
realshuting opened this issue Jun 23, 2021 · 6 comments · Fixed by #2081
Closed

Automate Helm Release Process #2057

realshuting opened this issue Jun 23, 2021 · 6 comments · Fixed by #2081
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@realshuting
Copy link
Member

Is your feature request related to a problem? Please describe.
The Helm chart is published manually by uploading assets to gh-pages branch. It would good to automate this process in the CI workflow, any changes in the chart can then be picked up and published accordingly, see #2052 (comment).

@realshuting realshuting added enhancement New feature or request help wanted Extra attention is needed labels Jun 23, 2021
@realshuting realshuting mentioned this issue Jun 23, 2021
3 tasks
@DarthBenro008
Copy link
Contributor

DarthBenro008 commented Jun 23, 2021

Hi @realshuting , I came across this GitHub action @helm/chart-releaser-action and thought would be useful for this scenario, but I noticed Kyverno's GitHub CI already makes use of this in the release.yaml

- name: Run chart-releaser
uses: helm/chart-releaser-action@v1.1.0
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

Ideally, shouldn't this action take care of automating the helm release?

@realshuting
Copy link
Member Author

Yes @DarthBenro008 , we had this working before and it was broken at some point. Last time I tried investigating the issue but with no luck, so we switched to the manual release process. The difficult thing is how to test this action, we cannot really push a new Helm release to test that, it's better to test it locally or in some other private repo.

@DarthBenro008
Copy link
Contributor

@realshuting i think temporary testing in a new branch of a forked repo would workout, if not we could write a small bash script automation that can be called by the CI to release helm charts.

I'd like to help in this investigation and see if we can use the chart-releaser-action to work 😃

@realshuting
Copy link
Member Author

Thanks @DarthBenro008, assigned!

@treydock
Copy link
Member

@DarthBenro008 @realshuting That chart releaser doesn't work with tags. This is what happens in Github Action:

Nothing to do. No chart changes detected.

This is a well known and frustrating "feature" of the official Helm releaser action. I ran into this on some of my projects and also had MetalLB developers run into it too. The solution is a different chart releaser, like this one: https://github.com/marketplace/actions/helm-publisher

I use that on several of my projects where I release Helm charts to match the tag they are released against. Like here: https://github.com/OSC/k8-ldap-configmap/blob/main/.github/workflows/release.yaml#L48-L51. This one has served me well as I use the same chart version and release scheme as Kyverno.

@realshuting
Copy link
Member Author

This is great @treydock, good to know!

treydock added a commit to treydock/kyverno that referenced this issue Jun 29, 2021
Fixes kyverno#2057

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
@realshuting realshuting added this to the Kyverno Release 1.4.2 milestone Jun 29, 2021
realshuting pushed a commit that referenced this issue Jun 29, 2021
Fixes #2057

Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants