fix: return skip when celPreconditions/matchConditions aren't met (cherry-pick #9940) #10085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
) * fix: return skip when cel preconditions aren't met Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> * fix test Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> * fix: return skip when matchConditions in VAPs aren't met Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> --------- Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
gcp-cherry-pick-bot
bot
requested review from
chipzoller,
eddycharly,
realshuting,
MariamFahmy98 and
MarcelMue
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #10085 +/- ##
================================================
- Coverage 33.60% 33.59% -0.01%
================================================
Files 347 347
Lines 23870 23877 +7
================================================
Hits 8021 8021
- Misses 14967 14974 +7
Partials 882 882 ☔ View full report in Codecov by Sentry. |
realshuting
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: return skip when celPreconditions/matchConditions aren't met (#9940)
Signed-off-by: Mariam Fahmy mariam.fahmy@nirmata.com
Signed-off-by: Mariam Fahmy mariam.fahmy@nirmata.com
Signed-off-by: Mariam Fahmy mariam.fahmy@nirmata.com
Signed-off-by: Mariam Fahmy mariam.fahmy@nirmata.com