-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add resourceNames field in the generated VAPs #10187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
MariamFahmy98
requested review from
chipzoller,
eddycharly,
realshuting and
KhaledEmaraDev
as code owners
May 6, 2024 15:16
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10187 +/- ##
==========================================
- Coverage 10.15% 10.15% -0.01%
==========================================
Files 1030 1030
Lines 91785 91796 +11
==========================================
Hits 9319 9319
- Misses 81448 81457 +9
- Partials 1018 1020 +2 ☔ View full report in Codecov by Sentry. |
KhaledEmaraDev
approved these changes
May 7, 2024
Please make sure PRs are cherry-picked to patch versions. |
/cherry-pick release-1.12 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 20, 2024
Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
realshuting
added
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
milestone 1.13.0
labels
May 20, 2024
MariamFahmy98
added a commit
that referenced
this pull request
May 20, 2024
anushkamittal2001
pushed a commit
to nirmata/kyverno
that referenced
this pull request
May 24, 2024
…yverno#10265) Signed-off-by: Mariam Fahmy <mariam.fahmy@nirmata.com> Co-authored-by: Mariam Fahmy <mariam.fahmy@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.12.2
milestone 1.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds
resourceNames
field in the generated VAP in case Kyverno policy matches resources by names. Also, VAPs don't support wildcards in resource names so we skip generating them in case one of the resource names has a wildcard.Related issue
Closes #10186
Milestone of this PR
/milestone 1.12.2
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
/kind bug
Proposed Changes
Proof Manifests
Resource Names without wildcards
Resource names with wildcards
Checklist
Further Comments