-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): add new linter prealloc
to enforce slice declarations best practice
#10250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t practice Signed-off-by: ShutingZhao <shuting@nirmata.com>
prealloc
to enforce slice declarations best practice
Signed-off-by: ShutingZhao <shuting@nirmata.com>
/cherry-pick release-1.12 |
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Signed-off-by: ShutingZhao <shuting@nirmata.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
vishal-chdhry
approved these changes
May 20, 2024
Cherry-pick failed with |
realshuting
added a commit
to realshuting/kyverno
that referenced
this pull request
May 20, 2024
Signed-off-by: ShutingZhao <shuting@nirmata.com>
realshuting
added a commit
that referenced
this pull request
May 20, 2024
anushkamittal2001
pushed a commit
to nirmata/kyverno
that referenced
this pull request
May 24, 2024
Signed-off-by: ShutingZhao <shuting@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-completed
The PR was cherry-picked (or merged) to required release branches
cherry-pick-required
milestone 1.12.2
milestone 1.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds the linter https://github.com/alexkohler/prealloc to enforce slice definition best pracitices.
Related issue
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments