Helm namespace value #1210
Merged
Helm namespace value #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realshuting
reviewed
Oct 23, 2020
There was a problem hiding this comment.
@yufuluo Thanks for contributing!
/lgtm
Do we need these binaries .DS_Store and charts/.DS_Store?
realshuting
approved these changes
Oct 23, 2020
|
@realshuting Thanks for the review Shuting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#1209
What type of PR is this?
/kind feature
Proposed changes
Currently, the kyverno helm chart is deployed to the namespace with
.Release.Namespace. It will be good if users can also specify the target namespace in thevalues.yamlfile.I added a function to the
_helpers.tplto get namespace from.Values.namespaceif it's specified, otherwise, use.Release.Namespace.Checklist
works.
Further comments