Add Policy Report #1229
Merged
Add Policy Report #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erno into feature/reports-cli
…- remove reportRequests after merged to report
…equest to clusterReportChangeRequest
# Conflicts: # pkg/utils/util.go
clean up policy violation code - remove pvGenerator
JimBugwadia
requested changes
Nov 7, 2020
| case report.StatusPass: | ||
| summary.Pass += len(res.Resources) | ||
| case report.StatusFail: | ||
| summary.Fail++ |
There was a problem hiding this comment.
shouldn't this also include all resources?
summary.Fail+= len(res.Resources)
There was a problem hiding this comment.
This package pkg/kyverno/apply implements policy report generated by CLI, I believe it's changed in another PR. I'll check with @NoSkillGirl and send a patch if it's still there.
JimBugwadia
approved these changes
Nov 9, 2020
|
Merge this PR for release candidate, the CLI changes will be merged in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1215.
Closes #982, added PolicyReport, design doc https://hackmd.io/rCav-hkuQ0yOCzzdnRivYQ?view.
The policy report is enabled by default in v1.3.0 (no flag is needed), and policy violations are no longer supported in this version.
Track #1227 for violation clean up.