Improve logging message #1232
Merged
Improve logging message #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBugwadia
reviewed
Nov 4, 2020
| @@ -235,7 +235,7 @@ func MatchesResourceDescription(resourceRef unstructured.Unstructured, ruleRef k | |||
| } | |||
|
|
|||
| // creating final error | |||
| var errorMessage = "rule not matched:" | |||
| var errorMessage = fmt.Sprintf("rule %s not matched:", ruleRef.Name) | |||
There was a problem hiding this comment.
What does "rule <%s> was not matched" mean?
Is this indicating that the admission request / resource did not match the rule, or that the rule resulted in an a policy failure (i.e. violation).
I think its the latter, in which case the message is misleading.
The message could be, "rule %s result = fail" or "rule %s failed".
There was a problem hiding this comment.
It's actually the former, this function MatchesResourceDescription evaluates if the given resource matches the rule.
There was a problem hiding this comment.
Ok, then it seems fine. Thanks!
JimBugwadia
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1192.
Fixes #1224.
Fixes #1225.