Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1298 fix variable validation #1303

Merged
merged 8 commits into from
Nov 25, 2020
Merged

1298 fix variable validation #1303

merged 8 commits into from
Nov 25, 2020

Conversation

JimBugwadia
Copy link
Member

Related issue

Fixes #1298

What type of PR is this?

Further comments

realshuting
realshuting reviewed Nov 25, 2020
View reviewed changes
pkg/policy/validate.go Outdated Show resolved Hide resolved
realshuting
realshuting reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Can you fix test case?

@JimBugwadia JimBugwadia merged commit bfab77a into main Nov 25, 2020
@JimBugwadia JimBugwadia deleted the 1298_fix_variable_validation branch November 25, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@NoSkillGirl NoSkillGirl Awaiting requested review from NoSkillGirl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] invalid validation error for variable {{ request.object.spec.serviceAccountName }}
2 participants
@JimBugwadia @realshuting