Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webhook registration and monitor #1318

Merged
merged 7 commits into from
Nov 27, 2020
Merged

Conversation

JimBugwadia
Copy link
Member

Related issue

Fixes #1181 and #1295

What type of PR is this?

/kind bug

Proposed changes

Webhooks are no longer deleted on shutdown. Instead the controller will periodically check for webhooks and recreate if needed.

Checklist

Further comments

@realshuting
Copy link
Member

lgtm

One thing I'm confused - When you say Webhooks are no longer deleted on shutdown, do you mean when Kyverno shuts down? I can see we still remove the webhooks on shutdown:

go ws.webhookRegister.Remove(ws.cleanUp)

@JimBugwadia
Copy link
Member Author

Yes, looks like we were calling the remove webhooks in multiple places.

In my tests, I found that we actually need this for now as if the webhook name changes, it starts failing.

When we design for HA, we will need a better way to manage this. Lets revisit then.

@JimBugwadia
Copy link
Member Author

@realshuting can you please review the new commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rollingupdate strategy deregister policy webhook configurations
2 participants