Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1319 fix throttling #1341

Merged
merged 4 commits into from
Nov 30, 2020
Merged

1319 fix throttling #1341

merged 4 commits into from
Nov 30, 2020

Conversation

JimBugwadia
Copy link
Member

Related issue

Fixes #1319

What type of PR is this?

/kind bug

Proposed changes

  • Update policy status management logic to removed cached entry. Previously all status was being re-written every 10 seconds. This would cause all policies to be updates, triggering policy validation checks.
  • Added checks in controllers to only update policy status when there is a real change.
  • Changed resync intervals to 15 minutes and removed resync from listers.

Checklist

@realshuting realshuting merged commit 2344b2c into main Nov 30, 2020
@realshuting realshuting deleted the 1319_fix_throttling branch November 30, 2020 19:22
@realshuting realshuting mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@NoSkillGirl NoSkillGirl Awaiting requested review from NoSkillGirl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Generate rules trigger API server throttling
2 participants
@JimBugwadia @realshuting