removing generate error message #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoSkillGirl
requested review from
realshuting and
JimBugwadia
and removed request for
realshuting
realshuting
approved these changes
Dec 7, 2020
JimBugwadia
reviewed
Dec 8, 2020
| @@ -47,6 +48,12 @@ func (c *Controller) processGR(gr *kyverno.GenerateRequest) error { | |||
| events := failedEvents(err, *gr, *resource) | |||
| c.eventGen.Add(events...) | |||
|
|
|||
| // Need not update the stauts when policy doesn't apply on resource, because all the generate requests are removed by the cleanup controller | |||
| @@ -47,6 +48,12 @@ func (c *Controller) processGR(gr *kyverno.GenerateRequest) error { | |||
| events := failedEvents(err, *gr, *resource) | |||
| c.eventGen.Add(events...) | |||
|
|
|||
| // Need not update the stauts when policy doesn't apply on resource, because all the generate requests are removed by the cleanup controller | |||
| if err != nil && strings.Contains(err.Error(), "does not apply to resource") { | |||
There was a problem hiding this comment.
would be best not to use error strings for comparison, as these can be changed. Instead we can introduce an error type and check for that. See: https://blog.golang.org/go1.13-errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
closes #1320
What type of PR is this?
Proposed changes
skipping update of status for generate request
Checklist
works.