Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match/exclude ns resource name #1375

Merged
merged 1 commit into from
Dec 9, 2020
Merged

match/exclude ns resource name #1375

merged 1 commit into from
Dec 9, 2020

Conversation

JimBugwadia
Copy link
Member

Related issue

Fixes #1292.

What type of PR is this?

Proposed changes

Check namespace resource name against match / exclude ns list

Checklist

Further comments

@JimBugwadia JimBugwadia merged commit b7cecd0 into main Dec 9, 2020
@JimBugwadia JimBugwadia deleted the 1292_match_namespace branch December 9, 2020 07:05
@realshuting realshuting mentioned this pull request Dec 9, 2020
Closed
LaikaN57
LaikaN57 reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@LaikaN57 LaikaN57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review: 👍🏼 LGTM

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaikaN57 LaikaN57 LaikaN57 left review comments

@realshuting realshuting realshuting approved these changes

@NoSkillGirl NoSkillGirl Awaiting requested review from NoSkillGirl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Exclude statement ignored for generate rules
3 participants
@JimBugwadia @LaikaN57 @realshuting