Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enqueing gr on getting deleted #1405

Conversation

NoSkillGirl
Copy link
Contributor

@NoSkillGirl NoSkillGirl commented Dec 16, 2020

Related issue

closes #1374
closes #1420

What type of PR is this?

/kind bug

Proposed changes

Now kyverno recreates the generated resource if synchronization: true and generated resource is deleted by user.
Also, if clone source is updated, the generated cloned source will also be updated.

Checklist

@NoSkillGirl NoSkillGirl added the wip work in progress label Dec 16, 2020
@NoSkillGirl NoSkillGirl force-pushed the bug/1374_generate_rule_with_synchronization branch from 455b519 to 4192a78 Compare December 19, 2020 17:26
@NoSkillGirl NoSkillGirl changed the title [WIP] enqueing gr on getting deleted enqueing gr on getting deleted Dec 22, 2020
@NoSkillGirl NoSkillGirl removed the wip work in progress label Dec 22, 2020
@NoSkillGirl NoSkillGirl added this to the Kyverno Release 1.3.0 milestone Dec 22, 2020
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Added minor comments.

pkg/webhooks/server.go Show resolved Hide resolved
pkg/generate/generate.go Outdated Show resolved Hide resolved
pkg/generate/generate.go Show resolved Hide resolved
pkg/generate/generate.go Show resolved Hide resolved
pkg/generate/generate.go Show resolved Hide resolved
pkg/webhooks/generate/generate.go Outdated Show resolved Hide resolved
pkg/webhooks/generate/generate.go Show resolved Hide resolved
pkg/webhooks/generation.go Outdated Show resolved Hide resolved
pkg/webhooks/generate/generate.go Show resolved Hide resolved
@NoSkillGirl NoSkillGirl force-pushed the bug/1374_generate_rule_with_synchronization branch from 38d2d9e to e149d65 Compare December 23, 2020 18:17
@NoSkillGirl NoSkillGirl force-pushed the bug/1374_generate_rule_with_synchronization branch from e149d65 to 0a84225 Compare December 24, 2020 07:00
Copy link
Member

@JimBugwadia JimBugwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

pkg/generate/generate.go Outdated Show resolved Hide resolved
pkg/generate/cleanup/controller.go Outdated Show resolved Hide resolved
pkg/generate/generate.go Outdated Show resolved Hide resolved
pkg/generate/generate.go Outdated Show resolved Hide resolved
pkg/webhooks/generation.go Show resolved Hide resolved
pkg/webhooks/generation.go Outdated Show resolved Hide resolved
pkg/webhooks/generation.go Outdated Show resolved Hide resolved
pkg/webhooks/server.go Show resolved Hide resolved
@NoSkillGirl NoSkillGirl added the wip work in progress label Dec 28, 2020
@NoSkillGirl NoSkillGirl removed the wip work in progress label Dec 29, 2020
@JimBugwadia JimBugwadia self-requested a review January 1, 2021 00:38
@JimBugwadia JimBugwadia merged commit 5edb8b3 into kyverno:main Jan 1, 2021
@realshuting realshuting removed this from the Kyverno Release 1.3.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants