-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enqueing gr on getting deleted #1405
Merged
JimBugwadia
merged 21 commits into
kyverno:main
from
NoSkillGirl:bug/1374_generate_rule_with_synchronization
Jan 1, 2021
Merged
enqueing gr on getting deleted #1405
JimBugwadia
merged 21 commits into
kyverno:main
from
NoSkillGirl:bug/1374_generate_rule_with_synchronization
Jan 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoSkillGirl
force-pushed
the
bug/1374_generate_rule_with_synchronization
branch
from
December 19, 2020 17:26
455b519
to
4192a78
Compare
NoSkillGirl
changed the title
[WIP] enqueing gr on getting deleted
enqueing gr on getting deleted
Dec 22, 2020
realshuting
reviewed
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Added minor comments.
NoSkillGirl
force-pushed
the
bug/1374_generate_rule_with_synchronization
branch
from
December 23, 2020 18:17
38d2d9e
to
e149d65
Compare
NoSkillGirl
force-pushed
the
bug/1374_generate_rule_with_synchronization
branch
from
December 24, 2020 07:00
e149d65
to
0a84225
Compare
fixed updation of clone source
JimBugwadia
requested changes
Dec 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
realshuting
requested changes
Dec 28, 2020
JimBugwadia
approved these changes
Dec 31, 2020
JimBugwadia
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
closes #1374
closes #1420
What type of PR is this?
Proposed changes
Now kyverno recreates the generated resource if
synchronization: true
and generated resource is deleted by user.Also, if clone source is updated, the generated cloned source will also be updated.
Checklist
works.