update validation logic #1417

JimBugwadia · 2020-12-23T23:57:39Z

Related issue

Fixes #1337

What type of PR is this?

Change validation to match on both new and old resources. Refactor code.

[x ] I have read the contributing guidelines.
[x ] I have added tests that prove my fix is effective or that my feature
works.
I have added or changed the documentation.

realshuting

Have questions for buildResponse, see comments.

pkg/engine/validation.go

JimBugwadia added 2 commits December 23, 2020 15:10

update validation logic

e2f10c6

add test case

ed232ba

JimBugwadia requested review from realshuting and NoSkillGirl December 23, 2020 23:57

realshuting reviewed Dec 24, 2020

View reviewed changes

pkg/engine/validation.go Outdated Show resolved Hide resolved

pkg/engine/validation.go Show resolved Hide resolved

JimBugwadia added 2 commits December 23, 2020 18:46

fix validate response

204c1f7

fix patch resource in response

d3a65a0

realshuting approved these changes Dec 24, 2020

View reviewed changes

JimBugwadia merged commit 58feb4f into main Dec 24, 2020

JimBugwadia deleted the 1337_match_old_resource branch December 24, 2020 03:01