add logging for policy creation and deletion events #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realshuting
requested changes
Jan 6, 2021
.gitignore
Outdated
| @@ -9,3 +9,4 @@ cmd/initContainer/kyvernopre | |||
| cmd/kyverno/kyverno | |||
| cmd/cli/kubectl-kyverno/kyverno | |||
| kubectl-kyverno | |||
| vendor/ | |||
There was a problem hiding this comment.
We do not have vendor in Kyverno repo, please remove it.
pkg/policy/validate_controller.go
Outdated
| logger.V(4).Info("deleting policy", "name", p.Name) | ||
| logger.Info("deleting policy event", "uid", p.UID, "kind", "ClusterPolicy", "policy_name", p.Name) | ||
|
|
||
| //logger.V(4).Info("deleting policy", "name", p.Name) |
There was a problem hiding this comment.
Please remove commented log.
pkg/policy/validate_controller.go
Outdated
| @@ -235,6 +240,9 @@ func (pc *PolicyController) deletePolicy(obj interface{}) { | |||
| func (pc *PolicyController) addNsPolicy(obj interface{}) { | |||
| logger := pc.log | |||
| p := obj.(*kyverno.Policy) | |||
|
|
|||
| logger.Info("creating ns policy event", "uid", p.UID, "kind", "ClusterPolicy", "policy_name", p.Name, "namespaces", p.Namespace) | |||
pkg/policy/validate_controller.go
Outdated
| pol := ConvertPolicyToClusterPolicy(p) | ||
|
|
||
| logger.Info("deleting ns policy event", "uid", pol.UID, "kind", "ClusterPolicy", "policy_name", pol.Name, "namespaces", pol.Namespace) |
pkg/policy/validate_controller.go
Outdated
| pol := ConvertPolicyToClusterPolicy(p) | ||
|
|
||
| logger.Info("deleting ns policy event", "uid", pol.UID, "kind", "ClusterPolicy", "policy_name", pol.Name, "namespaces", pol.Namespace) | ||
|
|
||
| logger.V(4).Info("deleting namespace policy", "namespace", pol.Namespace, "name", pol.Name) |
pkg/policy/validate_controller.go
Outdated
| @@ -180,6 +180,9 @@ func (pc *PolicyController) canBackgroundProcess(p *kyverno.ClusterPolicy) bool | |||
| func (pc *PolicyController) addPolicy(obj interface{}) { | |||
| logger := pc.log | |||
| p := obj.(*kyverno.ClusterPolicy) | |||
|
|
|||
| logger.Info("creating policy event", "uid", p.UID, "kind", "ClusterPolicy", "policy_name", p.Name) | |||
There was a problem hiding this comment.
Let's change the message to "policy created".
pkg/policy/validate_controller.go
Outdated
| @@ -224,7 +227,9 @@ func (pc *PolicyController) deletePolicy(obj interface{}) { | |||
| } | |||
| } | |||
|
|
|||
| logger.V(4).Info("deleting policy", "name", p.Name) | |||
| logger.Info("deleting policy event", "uid", p.UID, "kind", "ClusterPolicy", "policy_name", p.Name) | |||
There was a problem hiding this comment.
Same here - "policy deleted".
realshuting
requested changes
Jan 6, 2021
pkg/policy/validate_controller.go
Outdated
| @@ -180,6 +180,9 @@ func (pc *PolicyController) canBackgroundProcess(p *kyverno.ClusterPolicy) bool | |||
| func (pc *PolicyController) addPolicy(obj interface{}) { | |||
| logger := pc.log | |||
| p := obj.(*kyverno.ClusterPolicy) | |||
|
|
|||
| logger.Info("policy created event", "uid", p.UID, "kind", "Policy", "policy_name", p.Name) | |||
There was a problem hiding this comment.
I should make it clearer in the last comment. In Kyverno, we have ClusterPolicy and Policy, similar to ClusterRole and Role, the ClusterPolicy is a cluster-wide resource and the Policy is a namespaced source.
So here the kind should be ClustserPolicy, or you can use p.Kind to get the kind.
There was a problem hiding this comment.
When I first started, I used p.Kind to get kind, but I found that what I got was empty, so I changed it to a fixed value. I understand what you mean, I will modify it again according to the correct kind type.
realshuting
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
closes #1264
What type of PR is this?
Proposed changes
Checklist
works.