Remove unnecessary JSON patches; fixes strategicMergePatch for tolerations #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
realshuting
changed the title
|
@realshuting - does this also cover this issue? #1419 If so, do we have test coverage of it. |
It removes the Tests are covered here. |
JimBugwadia
reviewed
Jan 19, 2021
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
realshuting
force-pushed
the
1216_remove_additional_patches
branch
from
d80e546
to
2345724
Compare
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
realshuting
force-pushed
the
1216_remove_additional_patches
branch
from
da01080
to
4ab6768
Compare
NoSkillGirl
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuting Zhao shutting06@gmail.com
Fixes #1216.
Fixes #1339.
Fixes #1419.