redo changes reverted by merge #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
realshuting
reviewed
Feb 2, 2021
| @@ -81,6 +81,9 @@ func filterRule(rule kyverno.Rule, policyContext *PolicyContext) *response.RuleR | |||
| return nil | |||
| } | |||
|
|
|||
| policyContext.JSONContext.Checkpoint() | |||
| defer policyContext.JSONContext.Restore() | |||
There was a problem hiding this comment.
Can you elaborate on why we need to copy/restore context per rule?
There was a problem hiding this comment.
Each rule can have separate variables in the context. For example, if a rule loads a config map, it is meant to be used as part of processing that rule and should not be available to subsequent rules.
There was a problem hiding this comment.
Each rule can have separate variables in the context. For example, if a rule loads a config map, it is meant to be used as part of processing that rule and should not be available to subsequent rules.
realshuting
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Bugwadia jim@nirmata.com
Related issue
These changes somehow got missed in the last PR....when I merged.
What type of PR is this?
Proposed changes
Checklist
works.
Further comments