New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
namespace selector #1532
Merged
realshuting
merged 13 commits into
kyverno:main
from
NoSkillGirl:bug/namespaceSelector_931
Feb 3, 2021
Merged
namespace selector #1532
realshuting
merged 13 commits into
kyverno:main
from
NoSkillGirl:bug/namespaceSelector_931
Feb 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
NoSkillGirl
force-pushed
the
bug/namespaceSelector_931
branch
from
February 3, 2021 11:21
7c633de
to
37fb9e2
Compare
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
NoSkillGirl
force-pushed
the
bug/namespaceSelector_931
branch
2 times, most recently
from
February 3, 2021 13:46
880448c
to
c60ef5a
Compare
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
3 tasks
realshuting
approved these changes
Feb 3, 2021
|
||
// // nsListerSynced returns true if the namespace store has been synced at least once | ||
// nsListerSynced cache.InformerSynced | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove it?
@@ -128,6 +134,9 @@ func NewController( | |||
UpdateFunc: c.updateGenericResource, | |||
}) | |||
|
|||
// c.nsLister = namespaces.Lister() | |||
// c.nsListerSynced = namespaces.Informer().HasSynced | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NoSkillGirl singhpooja240393@gmail.com
Related issue
#1482
#931
What type of PR is this?
Proposed changes
Added new field in policy rule - namespaceSelector
Checklist
works.