performed cleanups #1552
Merged
performed cleanups #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yashvardhan-kukreja Can you resolve conflicts? |
Signed-off-by: Yashvardhan Kukreja <yash.kukreja.98@gmail.com>
yashvardhan-kukreja
force-pushed
the
issue-1551/cleanups
branch
from
d0847bb
to
11f9e3d
Compare
|
done @realshuting |
vyankyGH
pushed a commit
that referenced
this pull request
Feb 9, 2021
Signed-off-by: vyankatesh_neualto <vyankatesh@neualto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yashvardhan Kukreja yash.kukreja.98@gmail.com
Related issue
closes #1551
What type of PR is this?
Proposed changes
removed redundant err checks, redundant use of composite literals and unreachable pieces of code.
Checklist
works.
Further comments