added: make target to auto generate code

[yashvardhan-kukreja]

Related issue

closes #1602

What type of PR is this

/kind feature

Proposed changes

Checklist

• I have read the contributing guidelines.
• I have added tests that prove my fix is effective or that my feature works.
• I have added or changed the documentation.

Further comments

The first commit just adds the make auto-generate target
The second commit is the code after running make auto-generate over the current state of main branch.

[yashvardhan-kukreja]

ptal @realshuting

[yashvardhan-kukreja]

@realshuting a quick update, I researched on this a few days back and couldn't find any way to auto generate code for informer, client and lister. I even looked at the source code of kubernetes/controller-tools to see if it is addressing informer, client and listers somewhere but it isn't.

I even raised an issue, some days back, on kubernetes/controller-tools asking this doubt but nobody replied there as well.

So, I guys we can close this issue/pr for now as there doesn't seem any plausible way to auto-generate informer,client and lister's code via controller-gen

[realshuting]

@realshuting a quick update, I researched on this a few days back and couldn't find any way to auto generate code for informer, client and lister. I even looked at the source code of kubernetes/controller-tools to see if it is addressing informer, client and listers somewhere but it isn't.

I even raised an issue, some days back, on kubernetes/controller-tools asking this doubt but nobody replied there as well.

So, I guys we can close this issue/pr for now as there doesn't seem any plausible way to auto-generate informer,client and lister's code via controller-gen

Sure, we can use the current tool to generate client code. But I also find this is useful to update deepcopy methods from a forked report, is it ready to merge?

[yashvardhan-kukreja]

Sorry I didn't get you. Which forked report are you exactly talking about?

[realshuting]

Sorry I didn't get you. Which forked report are you exactly talking about?

Ah my bad, I mean forked repo..

[yashvardhan-kukreja]

Sorry I didn't get you. Which forked report are you exactly talking about?

Ah my bad, I mean forked repo..

ohh, just to confirm, when you said "updating the deep copy methods from the forked repo", did u mean that we should still consider this PR (my forked repo) only for the */zz_generated.deecopy.go files (containing the auto generated deepcopy methods) ,and remove the Makefile related changes from the PR

If yes, then, yeah, I tested the auto-generated deepcopy methods in this PR and they are working fine.

[realshuting]

Yes, I think we can also keep the make command to update deepcopy methods. Can we change to an explicit name, make deepcopy-autogen or similar?

[yashvardhan-kukreja]

Yes, I think we can also keep the make command to update deepcopy methods. Can we change to an explicit name, make deepcopy-autogen or similar?

Agreed, I'll do that 👍🏼