-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operators): supporting subset checking #1613
Conversation
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
For subset definition reference check this.
UPDATE: |
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It would be good to add an additional test, see comments.
@@ -1013,3 +1013,105 @@ func Test_Eval_Equal_Var_Fail(t *testing.T) { | |||
t.Error("expected to fail") | |||
} | |||
} | |||
|
|||
// subset test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add another test -
key: [1.1.1.1, 4.4.4.4]
op: NotIn
value: [1.1.1.1, 2.2.2.2, 3.3.3.3]
@RinkiyaKeDad This is no longer the case, can you update it? We need to log an issue to track the doc updates in kyverno/website. |
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
@realshuting - updated the test and the definition. I have already opened a PR for the docs on the website repo. Please take a look at that. |
Signed-off-by: Arsh Sharma arshsharma461@gmail.com
Fixes #1367
What type of PR is this
Checklist