Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for - Generate policy fails if trigger resource name exceed 58 characters #1631

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

NoSkillGirl
Copy link
Contributor

@NoSkillGirl NoSkillGirl commented Feb 20, 2021

Signed-off-by: NoSkillGirl singhpooja240393@gmail.com

Related issue

closes #1624

What type of PR is this

/kind bug

Proposed changes

The issue was due to the label kyverno.io/generated-by which is a combination of source resource kind-namespace-name. The character count exceeds 63 chars if the name or namespace have more number of characters.
To resolve this issue label kyverno.io/generated-by is separated in three labels:
kyverno.io/generated-by-kind
kyverno.io/generated-by-namespace
kyverno.io/generated-by-name

Checklist

Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
pkg/generate/labels.go Show resolved Hide resolved
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use keywords fixes, closes to close the issue.

Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate policy fails if trigger resource name exceed 58 characters
2 participants