-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding parallel GitHub pipeline to reduce the build time #1635
Conversation
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
cc: @realshuting |
4c22906
to
6de466d
Compare
it is reducing image build time from 33 mins to 15-16 mins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Is there a way to run this job .github/workflows/krew.yaml
after the release page is generated? Otherwise Krew will complain about the missing release.
We can add release-cli-via-krew
to release.yaml
, but need to make sure it is not triggered on the RC release.
okay @realshuting , we can add release-cli-via-krew to release.yaml with this condition
|
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
@realshuting added release-cli-via-krew |
@@ -68,3 +181,23 @@ jobs: | |||
env: | |||
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | |||
|
|||
release-cli-via-krew: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this run after create-release
? Or these two run in parallel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after create-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right, I missed needs: create-release
.
@@ -68,3 +181,23 @@ jobs: | |||
env: | |||
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | |||
|
|||
release-cli-via-krew: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right, I missed needs: create-release
.
* refactoring github workflow Signed-off-by: rajdas98 <mail.rajdas@gmail.com> * refactoring github workflow Signed-off-by: rajdas98 <mail.rajdas@gmail.com> * stage-pipeline Signed-off-by: rajdas98 <mail.rajdas@gmail.com> * Refactoring release and push github workflow Signed-off-by: rajdas98 <mail.rajdas@gmail.com> * refactoring github workflow Signed-off-by: rajdas98 <mail.rajdas@gmail.com> * adding release-cli-via-krew Signed-off-by: rajdas98 <mail.rajdas@gmail.com> Signed-off-by: vyankatesh <vyankatesh@neualto.com>
Related issue
Issue- #1630
Adding parallel GitHub pipeline for kyverno, kyverno-cli and kyverno to reduce the build time
What type of PR is this
Proposed changes
Checklist
Further comments