Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parallel GitHub pipeline to reduce the build time #1635

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

imrajdas
Copy link
Contributor

Related issue

Issue- #1630

Adding parallel GitHub pipeline for kyverno, kyverno-cli and kyverno to reduce the build time

Screenshot 2021-02-23 at 1 07 52 AM

What type of PR is this

Proposed changes

Checklist

Further comments

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

cc: @realshuting

@imrajdas
Copy link
Contributor Author

it is reducing image build time from 33 mins to 15-16 mins

Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Is there a way to run this job .github/workflows/krew.yaml after the release page is generated? Otherwise Krew will complain about the missing release.
We can add release-cli-via-krew to release.yaml, but need to make sure it is not triggered on the RC release.

@imrajdas
Copy link
Contributor Author

okay @realshuting , we can add release-cli-via-krew to release.yaml with this condition

        tag=${GITHUB_REF#refs/*/}
        if [[ $tag =~ ^v[0-9]*.[0-9]*.[0-9]*$ ]]
        then
             # logic
        fi

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

@realshuting added release-cli-via-krew

@@ -68,3 +181,23 @@ jobs:
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

release-cli-via-krew:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this run after create-release? Or these two run in parallel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after create-release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, I missed needs: create-release.

@@ -68,3 +181,23 @@ jobs:
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

release-cli-via-krew:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, I missed needs: create-release.

@realshuting realshuting merged commit 7a1629a into kyverno:main Feb 22, 2021
@imrajdas imrajdas deleted the stage-pipeline branch February 23, 2021 05:29
@imrajdas imrajdas restored the stage-pipeline branch February 23, 2021 05:29
@imrajdas imrajdas deleted the stage-pipeline branch February 23, 2021 05:29
vyankyGH pushed a commit to vyankyGH/kyverno that referenced this pull request Feb 23, 2021
* refactoring github workflow

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>

* refactoring github workflow

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>

* stage-pipeline

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>

* Refactoring release and push github workflow

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>

* refactoring github workflow

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>

* adding release-cli-via-krew

Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
Signed-off-by: vyankatesh <vyankatesh@neualto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants