fix: added details regarding match.resources #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
realshuting
requested changes
Mar 2, 2021
pkg/api/kyverno/v1/policy_types.go
Outdated
| @@ -209,6 +211,8 @@ type ExcludeResources struct { | |||
| UserInfo `json:",omitempty" yaml:",omitempty"` | |||
|
|
|||
| // ResourceDescription contains information about the resource being created or modified. | |||
| // Requires at least one resource to be specified when under MatchResources, if not, | |||
| // then ExcludeResources should be present instead. | |||
There was a problem hiding this comment.
"Requires at least one resource ... " this does not apply to exclude.resources.
pkg/api/kyverno/v1/policy_types.go
Outdated
| @@ -198,6 +198,8 @@ type MatchResources struct { | |||
| UserInfo `json:",omitempty" yaml:",omitempty"` | |||
|
|
|||
| // ResourceDescription contains information about the resource being created or modified. | |||
| // Requires at least one resource to be specified when under MatchResources, if not, | |||
| // then ExcludeResources should be present instead. | |||
There was a problem hiding this comment.
Can we change to "Requires at least one tag to be ..."
There was a problem hiding this comment.
@RinkiyaKeDad From this validation, it seems that match is required in the rule definition:
kyverno/pkg/policy/validate.go
Lines 477 to 480 in 10c714d
So we need to remove "if not, then ExcludeResources should be present instead.".
There was a problem hiding this comment.
@realshuting - Made the edit, please review.
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
realshuting
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arsh Sharma arshsharma461@gmail.com
Related issue
Fixes #1394
What type of PR is this
Proposed changes
Checklist
Further comments