Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: test command should return a status code for failure / success #1655

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

vyankyGH
Copy link
Contributor

@vyankyGH vyankyGH commented Mar 1, 2021

Signed-off-by: Vyankatesh vyankateshkd@gmail.com

Related issue

What type of PR is this

/kind bug

Fixes #1620.

Proposed changes

Checklist

Further comments

Test command should return a status code for failure / success test cases

@vyankyGH vyankyGH changed the title Extends match / exclude to use APIGroup and APIVersion Fix: test command should return a status code for failure / success Mar 1, 2021
Signed-off-by: vyankatesh <vyankatesh@neualto.com>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyankd - is it ready to merge?

@vyankyGH
Copy link
Contributor Author

vyankyGH commented Mar 4, 2021

LGTM

@vyankd - is it ready to merge?

Yes.

@realshuting realshuting merged commit adb3817 into kyverno:main Mar 5, 2021
@vyankyGH vyankyGH deleted the bug/test_cli_code branch February 18, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test command should return a status code for failure / success test cases
3 participants