Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate renewer in webhook registration controller #1692

Merged
merged 11 commits into from Mar 16, 2021

Conversation

realshuting
Copy link
Member

@realshuting realshuting commented Mar 10, 2021

Related issue

What type of PR is this

/kind bug
/kind feature

This PR:

In this PR, Kyverno is able to read CA cert from existing secret during start. With this, it is possible to scale up to multiple replicas. It also adds a certificate renewer to automatically renew Kyverno managed certificates. When the cert is renewed, Kyverno forces a rolling update to re-register webhook configurations and to re-create the webhook server.

To optimize webhook registration, webhook monitor, and cert renewal process, I will migrate webhook controller to use controller-runtime framework, with leader election enabled, and send it in a separate PR.

Checklist

Further comments

Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
@realshuting realshuting marked this pull request as draft March 10, 2021 04:30
@realshuting realshuting changed the title Support Webhook HA Add certificate renewer in webhook registration controller Mar 10, 2021
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
@realshuting realshuting marked this pull request as ready for review March 11, 2021 03:05
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
Signed-off-by: Shuting Zhao <shutting06@gmail.com>
@realshuting realshuting merged commit c816cf3 into kyverno:main Mar 16, 2021
@realshuting realshuting deleted the webhook_ha branch March 17, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants