Make validateAPICall work with special characters in variables #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Mueller <marcel.mueller1@rwth-aachen.de>
MarcelMue
force-pushed
the
fix-apipath-validation
branch
from
00e517c
to
4f96232
Compare
realshuting
reviewed
Mar 22, 2021
pkg/policy/validate.go
Outdated
| @@ -681,7 +682,10 @@ func validateAPICall(entry kyverno.ContextEntry) error { | |||
| return fmt.Errorf("both configMap and apiCall are not allowed in a context entry") | |||
| } | |||
|
|
|||
| if _, err := engine.NewAPIPath(entry.APICall.URLPath); err != nil { | |||
| // Replace all variables to prevent validation failing on variable keys. | |||
| urlPath := variables.ReplaceAllVars(entry.APICall.URLPath, func(s string) string { return "variable" }) | |||
There was a problem hiding this comment.
@MarcelMue - thanks for submitting the fix!
Can we keep the same logic but change variable to a more unique name? "kyvernoapicallvariable" maybe?
Signed-off-by: Marcel Mueller <marcel.mueller1@rwth-aachen.de>
MarcelMue
force-pushed
the
fix-apipath-validation
branch
from
04517e7
to
c10a994
Compare
JimBugwadia
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
None - I went straight for the PR for now.
What type of PR is this
/kind bug
Proposed changes
This fixes an issue where
validateAPICallfails if a variable contains/and therefore exceeds the limit of 7 parts in the path.Example of such a circumstance (falsely failing validation):
The solution I went for, is to replace all variables with a simple string during validation.
Checklist
Further comments
I am not sure how valuable this validation is at all. It is easy to construct cases where a variable might be templated into a string containing one or multiple
/during execution of aClusterPolicy.The benefit of this change is that values from labels and annotations are treated correctly for now at least.
I am open to add unit tests if reviewers think it's sensible.