Fix Helm charts #1828
Merged
Fix Helm charts #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
realshuting
approved these changes
Apr 20, 2021
realshuting
reviewed
Apr 20, 2021
| {{- if eq (include "kyverno.podSecurityDefault" (merge (dict "name" $name) .)) "true" }} | ||
| apiVersion: kyverno.io/v1 | ||
| kind: ClusterPolicy | ||
| metadata: | ||
| name: {{ $name }} | ||
| name: disallow-add-capabilities |
There was a problem hiding this comment.
Do we want to hard code the name here? I didn't see this for other policies.
There was a problem hiding this comment.
Good catch, that was something I accidentally committed while trying to debug the original issue. I've reverted back to using $name variable.
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#1827
What type of PR is this
/kind bug
Proposed Changes
Fix Helm template rendering and make some parts a little more consistent
Proof Manifests
The following is now successful
Checklist
Further Comments