Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating synchronize lable in generated resource #1860

Conversation

NoSkillGirl
Copy link
Contributor

Signed-off-by: NoSkillGirl singhpooja240393@gmail.com

Related issue

Closes #1859

What type of PR is this

/kind bug

Proposed Changes

updating synchronize label in generated resource

Proof Manifests

check steps provided in issue

Checklist

  • I have read the contributing guidelines.
  • [] I have added tests that prove my fix is effective or that my feature works.
  • [] My PR contains new or altered behavior to Kyverno and
    • [] I have added or changed the documentation myself in an existing PR and the link is:
    • [] I have raised an issue in kyverno/website to track the doc update and the link is:
    • [] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.

Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
@realshuting realshuting added the wip work in progress label May 3, 2021
@realshuting
Copy link
Member

@NoSkillGirl - is this duplicate with #1880?

@NoSkillGirl
Copy link
Contributor Author

@NoSkillGirl - is this duplicate with #1880?

No both are different.

Condition for this PR - the label in the generated resource (policy.kyverno.io/synchronize: disable) is not getting updated according to the generate policy label (synchronize).

Condition for #1880 - even if the generate policy (with clone) is deleted, the resource generated because of this policy should not be deleted

@realshuting realshuting removed the wip work in progress label May 6, 2021
@realshuting
Copy link
Member

No both are different.

Condition for this PR - the label in the generated resource (policy.kyverno.io/synchronize: disable) is not getting updated according to the generate policy label (synchronize).

Condition for #1880 - even if the generate policy (with clone) is deleted, the resource generated because of this policy should not be deleted

My bad! Looks good.

@realshuting realshuting self-assigned this May 6, 2021
@realshuting realshuting merged commit 4296e69 into kyverno:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants