Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing additionalProperties from policy schema #1891

Merged
merged 2 commits into from
May 7, 2021
Merged

Removing additionalProperties from policy schema #1891

merged 2 commits into from
May 7, 2021

Conversation

NoSkillGirl
Copy link
Contributor

@NoSkillGirl NoSkillGirl commented May 7, 2021 •
edited

Signed-off-by: NoSkillGirl singhpooja240393@gmail.com

Related issue

closes #1867

What type of PR is this

/kind bug

Proposed Changes

For now, removing all these definitions to pass the CLI validation, as string map is validated when we parse the policy YAML to Go object.

Checklist

  • I have read the contributing guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • [] My PR contains new or altered behavior to Kyverno and
    • [] I have added or changed the documentation myself in an existing PR and the link is:
    • [] I have raised an issue in kyverno/website to track the doc update and the link is:
    • [] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.

Further Comments

@NoSkillGirl
removed additionalProperties from policy schema
0b6e174 
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
@NoSkillGirl NoSkillGirl added the wip work in progress label May 7, 2021
@NoSkillGirl
added test cases
873d1a7 
Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
@NoSkillGirl NoSkillGirl removed the wip work in progress label May 7, 2021
@realshuting realshuting merged commit e62f23c into kyverno:main May 7, 2021
mhmohona pushed a commit to mhmohona/kyverno that referenced this pull request Jun 14, 2021
@NoSkillGirl @mhmohona
Removing additionalProperties from policy schema (kyverno#1891)
79a0d41 
* removed additionalProperties from policy schema

Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>

* added test cases

Signed-off-by: NoSkillGirl <singhpooja240393@gmail.com>
Signed-off-by: Mahfuza Humayra Mohona <mhmohona@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realshuting realshuting realshuting approved these changes

@JimBugwadia JimBugwadia Awaiting requested review from JimBugwadia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Policies seen as invalid after 1.3.6-rc1 upgrade
2 participants
@NoSkillGirl @realshuting