Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass by value in policy cache #1895

Merged
merged 1 commit into from
May 8, 2021
Merged

Conversation

realshuting
Copy link
Member

@realshuting realshuting commented May 7, 2021

Signed-off-by: Shuting Zhao shutting06@gmail.com

Related issue

/bug

Fixes #1894.

cc @vyankyGH

What type of PR is this

Proposed Changes

Since we are not changing any values that are passed by reference, this PR passes those parameters by value instead.

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • [] I have added tests that prove my fix is effective or that my feature works.
  • [] My PR contains new or altered behavior to Kyverno and
    • [] I have added or changed the documentation myself in an existing PR and the link is:
    • [] I have raised an issue in kyverno/website to track the doc update and the link is:
    • [] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.

Further Comments

Signed-off-by: Shuting Zhao <shutting06@gmail.com>
@realshuting
Copy link
Member Author

@yashvardhan-kukreja - can you also help review the fix?

@yashvardhan-kukreja
Copy link
Contributor

@yashvardhan-kukreja - can you also help review the fix?

Sure 👍

@realshuting realshuting merged commit 09d6ec9 into kyverno:main May 8, 2021
@realshuting realshuting deleted the 1894_fix_panic branch May 10, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kyverno crashing due to the webhook server panic
3 participants