Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added PodDisruptionBudget in kustomize & helm #1979

Closed
wants to merge 4 commits into from

Conversation

haarchri
Copy link
Contributor

@haarchri haarchri commented Jun 8, 2021

Signed-off-by: Christopher Haar chhaar30@googlemail.com

What type of PR is this

/kind feature PodDisruptionBudget

Proposed Changes

added PodDisruptionBudget in kustomize & helm

Proof Manifests

apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
  labels:
    app: kyverno
    app.kubernetes.io/component: kyverno
    app.kubernetes.io/instance: kyverno
    app.kubernetes.io/managed-by: Kustomize
    app.kubernetes.io/name: kyverno
    app.kubernetes.io/part-of: kyverno
    app.kubernetes.io/version: v1.3.6
  name: kyverno
  namespace: kyverno
spec:
  minAvailable: 1
  selector:
    matchLabels:
      app: kyverno
      app.kubernetes.io/name: kyverno

Checklist

Christopher Haar added 3 commits June 8, 2021 12:25
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haarchri - thanks for the contribution, it looks good to me!

@JimBugwadia @chipzoller - can you please take a look?

charts/kyverno/Chart.yaml Outdated Show resolved Hide resolved
@JimBugwadia
Copy link
Member

I am not very clear on the current best practices for PDB, but should the default settings for a single replica contain:

minAvailable: 1

Will this potentially prevent nodes from being drained as discussed here jupyterhub/zero-to-jupyterhub-k8s#1934?

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
@haarchri
Copy link
Contributor Author

haarchri commented Jun 9, 2021

@JimBugwadia i changed the default for kustomize to

minAvailable: 0

for helm chart the default is disabled - and the other configuration is done in values.yaml

@realshuting
Copy link
Member

@JimBugwadia - is there any change needed at this point? Should we merge the PR?

@haarchri
Copy link
Contributor Author

did you need something for this PR to merge ?

@realshuting
Copy link
Member

Ping @JimBugwadia.

@JimBugwadia
Copy link
Member

@ojhaarjun1 - No. Apologies for the delay. We will get this merged soon.

@JimBugwadia JimBugwadia added this to the Kyverno Release 1.5.0 milestone Oct 2, 2021
@JimBugwadia JimBugwadia added the milestone 1.5.0 Issues and PRs for the 1.5.0 release. label Oct 2, 2021
@realshuting
Copy link
Member

Rebased and merged via #2463.

@realshuting realshuting closed this Oct 5, 2021
@haarchri haarchri deleted the pdb branch October 6, 2021 05:14
@realshuting realshuting added the enhancement New feature or request label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request milestone 1.5.0 Issues and PRs for the 1.5.0 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants