-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added PodDisruptionBudget in kustomize & helm #1979
Conversation
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haarchri - thanks for the contribution, it looks good to me!
@JimBugwadia @chipzoller - can you please take a look?
I am not very clear on the current best practices for PDB, but should the default settings for a single replica contain:
Will this potentially prevent nodes from being drained as discussed here jupyterhub/zero-to-jupyterhub-k8s#1934? |
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
@JimBugwadia i changed the default for kustomize to
for helm chart the default is disabled - and the other configuration is done in values.yaml |
@JimBugwadia - is there any change needed at this point? Should we merge the PR? |
did you need something for this PR to merge ? |
Ping @JimBugwadia. |
@ojhaarjun1 - No. Apologies for the delay. We will get this merged soon. |
Rebased and merged via #2463. |
Signed-off-by: Christopher Haar chhaar30@googlemail.com
What type of PR is this
/kind feature PodDisruptionBudget
Proposed Changes
added PodDisruptionBudget in kustomize & helm
Proof Manifests
Checklist