Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add value for override of namespace of serviceMonitor #2258

Merged
merged 2 commits into from Aug 12, 2021

Conversation

Issif
Copy link
Contributor

@Issif Issif commented Aug 12, 2021

Signed-off-by: Issif issif+github@gadz.org

Related issue

What type of PR is this

Proposed Changes

This PR concerns the Helm chart and allows to override the namespace of the ServiceMonitor, it's useful when Prometheus Operator considers only ServiceMonitor in a specific Namespace.

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • [] My PR contains new or altered behavior to Kyverno and
    • [] I have added or changed the documentation myself in an existing PR and the link is:
    • [] I have raised an issue in kyverno/website to track the doc update and the link is:
    • [] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.

Further Comments

Signed-off-by: Issif <issif+github@gadz.org>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Issif. Looks good overall, just added minor comment.

@@ -1,6 +1,6 @@
apiVersion: v1
name: kyverno
version: v2.0
version: v2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the version to v2.0.1, it would be best to follow the same versioning strategy with Kyverno (major.minor.patch).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I wasn't sure when I bumped it. The fix is coming asap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 👍

@realshuting realshuting self-assigned this Aug 12, 2021
Signed-off-by: Issif <issif+github@gadz.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants