Support GVK format is case sensitive

[vyankyGH]

Signed-off-by: Vyankatesh vyankateshkd@gmail.com

Related issue

closes #2253

Milestone of this PR

What type of PR is this

Proposed Changes

Proof Manifests

Resource.yaml

spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: deny-exec-myapp-maintenance
    match:
      resources:
        kinds:
        - "deployment"

After install policy -o yaml

spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: deny-exec-myapp-maintenance
    match:
      resources:
        kinds:
        - "Deployment"

Resource.yaml

spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: deny-exec-myapp-maintenance
    match:
      resources:
        kinds:
        - "batch.volcano.sh/v1alpha1/job"

After install policy -o yaml

spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: deny-exec-myapp-maintenance
    match:
      resources:
        kinds:
        - "batch.volcano.sh/v1alpha1/Job"

Resource.yaml

spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: deny-exec-myapp-maintenance
    match:
      resources:
        kinds:
          - configMap
          - pod
          - deployment

After install policy -o yaml

spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: deny-exec-myapp-maintenance
    match:
      resources:
        kinds:
          - ConfigMap
          - Pod
          - Deployment

Checklist

• I have read the contributing guidelines.
• I have added tests that prove my fix is effective or that my feature works.
• My PR contains new or altered behavior to Kyverno and
  • I have added or changed the documentation myself in an existing PR and the link is:
  • [] I have raised an issue in kyverno/website to track the doc update and the link is:
  • [] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.

Further Comments

[chipzoller]

Did you happen to test plural vs singular as well? I know it's not the subject of this PR but asking.

[vyankyGH]

Did you happen to test plural vs singular as well? I know it's not the subject of this PR but asking.
Yes, It will work.

[realshuting]

Can we convert the GVK dynamically while processing the policy? Mutating the policy may not work if mutating webhook is missing or the policy creation request is somehow missed.

[realshuting]

Can we convert the GVK dynamically while processing the policy? Mutating the policy may not work if mutating webhook is missing or the policy creation request is somehow missed.

@vyankyGH - what do you think?

[vyankyGH]

Can we convert the GVK dynamically while processing the policy? Mutating the policy may not work if mutating webhook is missing or the policy creation request is somehow missed.

@vyankyGH - what do you think?

Sorry, I missed comment. I will update to convert GVK while processing the policy.

[vyankyGH]

Added test cases.

[realshuting]

/LGTM

@vyankyGH - can you resolve conflict?

Any doc update needed?

[realshuting]

@vyankyGH - this solution won't work for resources like ConfigMap, ClusterRole, CronJob, etc. We need to leverage this util GetFormatedKind to match the GVK.