networkPolicy customization #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
|
cc: @realshuting |
|
Thanks @Namanl2001 , it looks good to me. @antoineozenne - can you please help review? |
antoineozenne
suggested changes
Sep 1, 2021
There was a problem hiding this comment.
Thanks for this modification, but it does not seem to allow access to the metrics-port (8000). The major problem in 2287 is this one. Maybe we could do something like https://github.com/bitnami/charts/blob/master/bitnami/redis-cluster/templates/networkpolicy.yaml#L33?
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
antoineozenne
approved these changes
Sep 8, 2021
realshuting
approved these changes
Sep 9, 2021
|
Seems to me this was never tested? networkPolicy support in 2.1.3 is totally broken and there's no documentation on how to use this refactored version. |
|
@windowsrefund there was an issue which was fixed in this pr #2423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287
Changes
Allowed customization for NetworkPolicy with namespaceSelector and podSelector via helm.
Verification
Verified locally