Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Namespace environment variable for initContainer #2499

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

kumar-mallikarjuna
Copy link
Collaborator

@kumar-mallikarjuna kumar-mallikarjuna commented Oct 7, 2021

Signed-off-by: Kumar Mallikarjuna kumarmallikarjuna1@gmail.com

cc - @realshuting

Related issue

Milestone of this PR

/milestone 1.5.0

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • [] I have added tests that prove my fix is effective or that my feature works.
  • My PR contains new or altered behavior to Kyverno and
    • [] I have added or changed the documentation myself in an existing PR and the link is:
    • [] I have raised an issue in kyverno/website to track the doc update and the link is:
    • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.

Further Comments

Signed-off-by: Kumar Mallikarjuna <kumarmallikarjuna1@gmail.com>
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ojhaarjun1 . Can you please update the env in definitions/manifest/deployment.yaml and run make kubstomize-crd to update all manifest? We also need it in Helm manifest.

@kumar-mallikarjuna
Copy link
Collaborator Author

I think the Helm chart already has this change:

- name: KYVERNO_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace

@realshuting realshuting added the milestone 1.5.0 Issues and PRs for the 1.5.0 release. label Oct 7, 2021
@realshuting realshuting merged commit f67f847 into kyverno:main Oct 7, 2021
@realshuting realshuting added the bug Something isn't working label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working milestone 1.5.0 Issues and PRs for the 1.5.0 release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants