Handle reports with missing result property #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelMue
previously approved these changes
Nov 8, 2021
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
AverageMarcus
force-pushed
the
fix_missing_result
branch
from
b4ca00b
to
dccb816
Compare
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
MarcelMue
reviewed
Nov 9, 2021
| @@ -225,3 +215,8 @@ func isDeletedPolicyKey(key string) (policyName, ruleName string, isDelete bool) | |||
|
|
|||
| return "", "", false | |||
| } | |||
|
|
|||
| func mapToStruct(in, out interface{}) error { | |||
There was a problem hiding this comment.
Is mapToStruct an accurate name here? I don't have a better suggestion unfortunately 😅
MarcelMue
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
@realshuting This PR is a first step to using more strongly typed structs in the code. It saves us a lot type casting all over the place. We would like to do this in more places. Let's check in the next contributor meeting.
Sure. |
fiunchinho
pushed a commit
to fiunchinho/kyverno
that referenced
this pull request
Nov 11, 2021
* Handle reports with missing result property Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Make use of type structs Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Fix import Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Fix cast from map to struct Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
realshuting
pushed a commit
to realshuting/kyverno
that referenced
this pull request
Nov 30, 2021
* Handle reports with missing result property Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Make use of type structs Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Fix import Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Fix cast from map to struct Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
realshuting
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Handle reports with missing result property Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Make use of type structs Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Fix import Signed-off-by: Marcus Noble <github@marcusnoble.co.uk> * Fix cast from map to struct Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
We experienced an issue where we had PolicyReports without a
resultproperty in theirresults. We're not 100% clear how this happened by my best guess is they were previously v1alpha1 and were converted to v1alpha2 incorrectly somehow.The missing
resultproperty results in Kyverno crashing on startup due to a nil pointer. This change guards against that nil pointer to at least allow Kyverno to start up successfully.Milestone of this PR
What type of PR is this
/kind bug
Proposed Changes
Proof Manifests
N/A
Checklist
Further Comments