Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best practice policies #366

Merged
merged 9 commits into from
Oct 8, 2019
Merged

Add best practice policies #366

merged 9 commits into from
Oct 8, 2019

Conversation

realshuting
Copy link
Member

No description provided.

Copy link
Contributor

@shivdudhani shivdudhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few scenarios files with policy success and some with failure as expected result. It would be better to have a pass/fail per policy as it would help in testing looking for both cases.

@realshuting
Copy link
Member Author

We have a few scenarios files with policy success and some with failure as expected result. It would be better to have a pass/fail per policy as it would help in testing looking for both cases.

Those testing scenarios guarantee each commit not break the best practice cases. Agree for the case you described, we should have the unit tests to cover both pass and failure scenarios, otherwise the resources in the /resources folder would be doubled (even more), which makes the example harder to browse.

@shivdudhani
Copy link
Contributor

Let's update the policies to capture issue #371 and also add success/failure scenarios in the next PR.

@shivdudhani shivdudhani merged commit d973e84 into master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants