Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update engineResponse Name #369

Merged
merged 2 commits into from
Oct 8, 2019
Merged

update engineResponse Name #369

merged 2 commits into from
Oct 8, 2019

Conversation

shivdudhani
Copy link
Contributor

@shivdudhani shivdudhani commented Oct 8, 2019

Renaming of EngineResponseNew to EngineResponse

fixes #369

@shivdudhani
Copy link
Contributor Author

shivdudhani commented Oct 8, 2019

The build fails for "scenario_validate_hostpid_hostipc", as the testrunner uses "scheme.Codecs.UniversalDeserializer().Decode" and deserializer doesnt parse if the value defined is default value:
example:

spec:
  hostPID: false
  hostIPC: true

hostPID is not deserlised as its default value for that field.

The issue described in #371

@realshuting
Copy link
Member

I remembered we had this build issue before due to the cache of the test, running a clean test may resolve this issue, but yes, we need to solve this and make build process stable.

@realshuting realshuting merged commit 5c38c28 into master Oct 8, 2019
@shivdudhani shivdudhani deleted the 368_bug branch October 23, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants