Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix golangcilint timeout #4388

Merged
merged 5 commits into from
Aug 24, 2022
Merged

chore: fix golangcilint timeout #4388

merged 5 commits into from
Aug 24, 2022

Conversation

eddycharly
Copy link
Member

Signed-off-by: Charles-Edouard Brétéché charled.breteche@gmail.com

Explanation

golangcilint times out and when it happens the ci check doesn't fail, this makes the linter useless.
This PR increases the timeout allowed for golangcilint.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #4388 (3c90f3b) into main (0cc4d9b) will increase coverage by 0.00%.
The diff coverage is 22.22%.

@@           Coverage Diff           @@
##             main    #4388   +/-   ##
=======================================
  Coverage   30.76%   30.77%           
=======================================
  Files         146      146           
  Lines       19477    19460   -17     
=======================================
- Hits         5993     5989    -4     
+ Misses      12753    12740   -13     
  Partials      731      731           
Impacted Files Coverage Δ
cmd/cli/kubectl-kyverno/utils/common/common.go 12.88% <0.00%> (+0.01%) ⬆️
cmd/cli/kubectl-kyverno/utils/common/fetch.go 8.44% <0.00%> (ø)
pkg/background/generate/generate.go 0.00% <ø> (ø)
pkg/cosign/cosign.go 21.36% <0.00%> (ø)
pkg/dclient/discovery.go 6.52% <ø> (+0.07%) ⬆️
pkg/dclient/fake.go 57.40% <ø> (ø)
pkg/openapi/fake.go 0.00% <ø> (ø)
pkg/policy/validate.go 47.28% <ø> (-0.08%) ⬇️
pkg/policyreport/changerequestcreator.go 0.00% <0.00%> (ø)
pkg/policyreport/fake.go 0.00% <ø> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants